Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased Marker coverage #738

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 12, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Oct 12, 2022
@ahcorde ahcorde requested a review from iche033 as a code owner October 12, 2022 21:26
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #738 (043a03e) into ign-rendering3 (0c55e6a) will increase coverage by 0.60%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           ign-rendering3     #738      +/-   ##
==================================================
+ Coverage           77.06%   77.66%   +0.60%     
==================================================
  Files                 100      100              
  Lines                7805     7805              
==================================================
+ Hits                 6015     6062      +47     
+ Misses               1790     1743      -47     
Impacted Files Coverage Δ
ogre2/src/Ogre2DynamicRenderable.cc 53.89% <0.00%> (+0.93%) ⬆️
ogre2/src/Ogre2Marker.cc 86.32% <0.00%> (+37.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iche033
Copy link
Contributor

iche033 commented Oct 12, 2022

oh some time ago I added more tests for this class but targeted at ign-rendering6, #673. The changes look good here though. We'll just to make sure we combine these checks when merging forward.

FYI, there are other tests that got merged in fortress but not backported to citadel: #671, #670, #668

@ahcorde ahcorde marked this pull request as draft October 12, 2022 22:37
@ahcorde ahcorde marked this pull request as ready for review October 13, 2022 10:37
@ahcorde ahcorde enabled auto-merge (squash) October 13, 2022 11:00
@ahcorde ahcorde merged commit c542cc8 into ign-rendering3 Oct 13, 2022
@ahcorde ahcorde deleted the ahcorde/3/coverage/marker branch October 13, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants