Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport Citadel] Increase TransformControl test converage (#668) #741

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 12, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Related with gazebosim/gz-sim#1575

Backport https://github.com/gazebosim/gz-rendering/pull/668/files

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@ahcorde ahcorde requested a review from iche033 as a code owner October 12, 2022 22:23
@ahcorde ahcorde self-assigned this Oct 12, 2022
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #741 (713c616) into ign-rendering3 (c542cc8) will increase coverage by 1.34%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           ign-rendering3     #741      +/-   ##
==================================================
+ Coverage           77.66%   79.01%   +1.34%     
==================================================
  Files                 100      100              
  Lines                7805     7805              
==================================================
+ Hits                 6062     6167     +105     
+ Misses               1743     1638     -105     
Impacted Files Coverage Δ
include/ignition/rendering/base/BaseGizmoVisual.hh 88.02% <0.00%> (+0.49%) ⬆️
src/TransformController.cc 90.18% <0.00%> (+31.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde merged commit 3522325 into ign-rendering3 Oct 13, 2022
@ahcorde ahcorde deleted the ahcorde/3/coverage/transform_control branch October 13, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants