Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Model::CanonicalLink getter #1594

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Conversation

chapulina
Copy link
Contributor

🎉 New feature

Summary

Add a convenient function to get a model's canonical link.

Test it

See the added tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the MBARI buoy Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim label Jul 15, 2022
@chapulina chapulina mentioned this pull request Jul 15, 2022
9 tasks
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #1594 (b79126b) into ign-gazebo3 (df45262) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           ign-gazebo3    #1594      +/-   ##
===============================================
- Coverage        77.76%   77.72%   -0.04%     
===============================================
  Files              250      250              
  Lines            14443    14447       +4     
===============================================
- Hits             11231    11229       -2     
- Misses            3212     3218       +6     
Impacted Files Coverage Δ
include/ignition/gazebo/Model.hh 100.00% <ø> (ø)
src/Model.cc 95.83% <100.00%> (+0.24%) ⬆️
src/SimulationRunner.cc 93.45% <0.00%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df45262...b79126b. Read the comment docs.

@chapulina chapulina added the 🏰 citadel Ignition Citadel label Jul 15, 2022
@chapulina chapulina merged commit 33a0fce into ign-gazebo3 Jul 15, 2022
@chapulina chapulina deleted the chapulina/3/canonical branch July 15, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel MBARI buoy Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants