Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative install paths for plugin shared libraries and gz-tools data #2358

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 4, 2024

🦟 Bug fix

Summary

Fixes an error when building https://github.com/gazebo-release/gz_sim_vendor/ in the ROS buildfarm.

Similar to gazebosim/gz-tools#137

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from mjcarroll as a code owner April 4, 2024 18:13
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Apr 4, 2024
@azeey
Copy link
Contributor Author

azeey commented Apr 10, 2024

This can be tested by going into the build directory and running

cmake -DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON -P cmake_install.cmake

(Make sure to have the latest version of gz-cmake3)

@azeey azeey merged commit 1a54e96 into gz-sim8 Apr 11, 2024
8 checks passed
@azeey azeey deleted the azeey/rel_paths branch April 11, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants