Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignition -> Gazebo #100

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Ignition -> Gazebo #100

merged 2 commits into from
Jul 18, 2022

Conversation

jennuine
Copy link
Contributor

🦟 Bug fix

Part of:

Summary

Updated links and naming in README.md

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@jennuine
Ignition -> Gazebo
1170184 
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@jennuine jennuine added the QA Quality assurance. label Jul 15, 2022
@jennuine jennuine requested a review from chapulina July 15, 2022 21:33
@jennuine jennuine requested a review from caguero as a code owner July 15, 2022 21:33
@jennuine jennuine self-assigned this Jul 15, 2022
@github-actions github-actions bot added 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Jul 15, 2022
chapulina
chapulina approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a comment about the coverage badge

README.md Outdated Show resolved Hide resolved
@jennuine
removed coverage badge
faa16bf 
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@chapulina chapulina merged commit 4e79cc3 into ign-tools1 Jul 18, 2022
@chapulina chapulina deleted the jennuine/readme_updates branch July 18, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees

@jennuine jennuine

Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress QA Quality assurance.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennuine @chapulina