Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fork experience #29

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Improve fork experience #29

merged 1 commit into from
Oct 26, 2020

Conversation

chapulina
Copy link
Contributor

Our GitHub actions haven't been running correctly for forks. This should fix all of them:

CI

CI only on push means that PRs from forks aren't tested. Adding pull_request fixes forks, with the downside of triggering duplicated jobs for PRs coming from branches in this repo.

Fixed the focal CI to actually be focal.

Labeler

Resolves gazebo-tooling/pr-collection-labeler#4.

Uses the new pull_request_target event.

Tested here: gazebosim/testing#14

Triage

Like above, uses the new pull_request_target event.

Tested here: gazebosim/testing#15

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Oct 14, 2020
@chapulina chapulina added the 🏢 edifice Ignition Edifice label Oct 14, 2020
@chapulina chapulina merged commit 6232765 into ign-tools1 Oct 26, 2020
@chapulina chapulina deleted the chapulina/1/forkX branch October 26, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants