Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ; as IGN_CONFIG_PATH delimiter on windows #45

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Use ; as IGN_CONFIG_PATH delimiter on windows #45

merged 2 commits into from
Mar 22, 2021

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes #43

Summary

The ign tool looks in the IGN_CONFIG_PATH environment variable for a : delimited list of paths to search for ignition command files. Since Windows paths have : (for example C:\), this logic incorrectly splits windows paths.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@scpeters
Use ; as IGN_CONFIG_PATH delimiter on windows
a3740ce 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from j-rivero March 22, 2021 22:56
@scpeters scpeters requested a review from caguero as a code owner March 22, 2021 22:56
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Mar 22, 2021
@scpeters scpeters mentioned this pull request Mar 22, 2021
Closed
@chapulina chapulina added beta Targeting beta release of upcoming collection bug Something isn't working Windows Windows support labels Mar 22, 2021
@scpeters scpeters merged commit d5fe8f2 into gazebosim:ign-tools1 Mar 22, 2021
@scpeters scpeters deleted the windows_env_path_delimiter branch March 22, 2021 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
beta Targeting beta release of upcoming collection bug Something isn't working 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice Windows Windows support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to parse IGN_CONFIG_PATH on windows due to : delimiter
3 participants
@scpeters @j-rivero @chapulina