Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort versions correctly. #50

Merged
merged 3 commits into from
May 6, 2021
Merged

Sort versions correctly. #50

merged 3 commits into from
May 6, 2021

Conversation

caguero
Copy link
Contributor

@caguero caguero commented May 3, 2021 •
edited
Loading

Signed-off-by: Carlos Agüero caguero@openrobotics.org

🦟 Bug fix

Fixes #48

Summary

Before this patch, ign was sorting all library versions alphabetically. Thus, version 10.0.0 was considered lower than 2.0.0. This should be fixed now.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@caguero
Sort versions correctly.
66cc2ea 
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels May 3, 2021
@caguero
Style.
fd2083c 
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero
Style.
c0b04fe 
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero caguero mentioned this pull request May 3, 2021
Closed
@chapulina chapulina requested a review from j-rivero May 3, 2021 18:51
@adlarkin
Copy link

adlarkin commented May 3, 2021

I believe that you mean this PR fixes #48, not 84?

@caguero
Copy link
Contributor Author

caguero commented May 3, 2021

I believe that you mean this PR fixes #48, not 84?

Thanks! 🙃

@caguero caguero merged commit 2cca470 into ign-tools1 May 6, 2021
@caguero caguero deleted the caguero/issue_48 branch May 6, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ign command version comparison needs natural sort order
3 participants
@caguero @adlarkin @scpeters