Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ruby find_program and ronn. Not really used #53

Merged
merged 5 commits into from
Jun 23, 2021
Merged

Remove ruby find_program and ronn. Not really used #53

merged 5 commits into from
Jun 23, 2021

Conversation

j-rivero
Copy link
Contributor

🦟 Issue fix

Summary

The build process is not using ruby or ruby-ronn at all. Remove it from CMake.

Checklist

  • Signed all commits for DCO

Note to maintainers: Remember to use Squash-Merge

@j-rivero
Remove ruby find_program and ronn. Not really used
6cef069 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero j-rivero requested a review from caguero as a code owner June 19, 2021 19:44
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Jun 19, 2021
@j-rivero
Remove ruby-ronn file
6a1cb5d 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Add changelog entry
bc14142 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
chapulina
chapulina approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we can also remove ruby-ronn from the README?

@j-rivero
Copy link
Contributor Author

LGTM, I think we can also remove ruby-ronn from the README?

done! thanks.

@j-rivero j-rivero enabled auto-merge (squash) June 22, 2021 21:00
@j-rivero j-rivero merged commit 48cad79 into ign-tools1 Jun 23, 2021
@j-rivero j-rivero deleted the no_ruby_dep branch June 23, 2021 15:04
@scpeters scpeters mentioned this pull request Mar 15, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@chapulina chapulina chapulina approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-rivero @ahcorde @chapulina