Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all cmake code related to compilations #55

Merged
merged 4 commits into from
Jun 22, 2021
Merged

Remove all cmake code related to compilations #55

merged 4 commits into from
Jun 22, 2021

Conversation

j-rivero
Copy link
Contributor

🦟 Issue fix

Summary

The library is composed by no more than ruby code, I see no reason to keep compilation related code. Probably copied from Gazebo when this repository was created.

Checklist

  • Signed all commits for DCO

Note to maintainers: Remember to use Squash-Merge

@j-rivero
Remove all cmake code related to compilations
6f06c66 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Add changelog entry
67890ac 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero j-rivero requested a review from caguero as a code owner June 19, 2021 20:28
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Jun 19, 2021
@j-rivero
Back to call src. No ign otherwise
cbabbb2 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@mjcarroll mjcarroll self-requested a review June 21, 2021 15:46
@mjcarroll
Fix typo
f0dae30 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
mjcarroll
mjcarroll approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Green CI.

@j-rivero j-rivero merged commit c8e8c93 into ign-tools1 Jun 22, 2021
@j-rivero j-rivero deleted the cleanup_compilation branch June 22, 2021 21:00
This was referenced Jun 23, 2021
Closed
Closed
@chapulina chapulina mentioned this pull request Jun 26, 2021
Merged
7 tasks
scpeters added a commit that referenced this pull request Sep 28, 2021
@scpeters
merge changelog entries
6627515 
PR #56 fixed a bug in #55 so merge their entries

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
caguero pushed a commit that referenced this pull request Sep 28, 2021
@chapulina @scpeters
🎈 1.3.0 (#62)
793bf18 
* 🎈 1.3.0

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* merge changelog entries

PR #56 fixed a bug in #55 so merge their entries

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@caguero caguero caguero approved these changes

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-rivero @mjcarroll @caguero