Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to get standard-compliant exception handling #68

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Add flag to get standard-compliant exception handling #68

merged 2 commits into from
Oct 26, 2021

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Oct 26, 2021

🦟 Bug fix

Summary

This should fix the following compiler warning with MSVC

 warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc

Checklist

Note to maintainers: Remember to use Squash-Merge

@azeey
Add flag to get standard-compliant exception handling
5f7f5b6 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from scpeters October 26, 2021 15:38
@azeey azeey requested a review from caguero as a code owner October 26, 2021 15:38
@github-actions github-actions bot added 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Oct 26, 2021
@azeey azeey mentioned this pull request Oct 26, 2021
Closed
7 tasks
Blast545
Blast545 approved these changes Oct 26, 2021
View reviewed changes
Copy link

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azeey
Copy link
Contributor Author

azeey commented Oct 26, 2021 •
edited
Loading

I'm going to test this on a release build before merging.

Build Status

@azeey
Use add_compile_options earlier so it's picked up by the backward target
96f7c2a 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey merged commit b764a7c into ign-tools1 Oct 26, 2021
@azeey azeey deleted the azeey/msvc_ehsc branch October 26, 2021 16:17
@Blast545 Blast545 mentioned this pull request Oct 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blast545 Blast545 Blast545 approved these changes

@scpeters scpeters Awaiting requested review from scpeters

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azeey @Blast545