ign -> gz CLI Migration : gz-tools #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
methylDragon
force-pushed
the
cli_migration
branch
4 times, most recently
from
567a708
to
5c77b63
Compare
|
The CMakeLists.txt changes are quite scuffed. I needed to contort it because execute_process isn't expanding the $ generator expression... |
methylDragon
force-pushed
the
cli_migration
branch
from
5c77b63
to
067dcc7
Compare
chapulina
reviewed
Jun 15, 2022
methylDragon
force-pushed
the
cli_migration
branch
3 times, most recently
from
894cc66
to
7df9dc4
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
cli_migration
branch
2 times, most recently
from
285a312
to
373ebf1
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
cli_migration
branch
from
373ebf1
to
24e3a9f
Compare
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
Windows tick-tock was failing, I tried various things without success, they're documented on the commit history of this PR. We don't need to block on Windows tick-tock, since Windows support is very limited at the moment anyway (see #7). So let's proceed as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: gazebo-tooling/release-tools#739