Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ignition #424

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Remove ignition #424

merged 3 commits into from
Aug 4, 2023

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 27, 2023

🎉 New feature

Remove ignition

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig nkoenig requested a review from caguero as a code owner July 27, 2023 12:45
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #424 (0e2c61c) into main (da3c55d) will increase coverage by 0.21%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 0e2c61c differs from pull request most recent head f01683f. Consider uploading reports for the commit f01683f to get more accurate results

@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
+ Coverage   87.14%   87.36%   +0.21%     
==========================================
  Files          61       59       -2     
  Lines        5462     5747     +285     
==========================================
+ Hits         4760     5021     +261     
- Misses        702      726      +24     

see 36 files with indirect coverage changes

Signed-off-by: Nate Koenig <natekoenig@gmail.com>
CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@mjcarroll mjcarroll enabled auto-merge (squash) August 4, 2023 13:50
@mjcarroll mjcarroll disabled auto-merge August 4, 2023 13:54
@mjcarroll mjcarroll merged commit 3a11524 into main Aug 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants