Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition utils to use bzlmod to build #128

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Apr 23, 2024

bzlmod is the new external dependency management system for bazel https://docs.bazel.build/versions/main/bzlmod.html)

This migrates gz-utils to use bzlmod via rules_gazebo.

@azeey azeey added beta Targeting beta release of upcoming collection and removed beta Targeting beta release of upcoming collection labels Jul 29, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 22.36842% with 59 lines in your changes missing coverage. Please review.

Project coverage is 72.26%. Comparing base (3838ce6) to head (9d95231).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
log/src/Logger.cc 0.00% 43 Missing ⚠️
log/src/SplitSink.cc 44.82% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   81.79%   72.26%   -9.53%     
==========================================
  Files           8       11       +3     
  Lines         401      476      +75     
==========================================
+ Hits          328      344      +16     
- Misses         73      132      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjcarroll mjcarroll changed the base branch from main to gz-utils3 September 17, 2024 15:44
@mjcarroll mjcarroll force-pushed the mjcarroll/bzlmod branch 2 times, most recently from 381536e to 8956b17 Compare September 30, 2024 22:13
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll changed the title Attempt at building gz-utils with bzlmod Transition utils to use bazel modules Oct 8, 2024
@mjcarroll mjcarroll changed the title Transition utils to use bazel modules Transition utils to use bzlmod to build Oct 8, 2024
@mjcarroll mjcarroll marked this pull request as ready for review October 8, 2024 14:48
@mjcarroll mjcarroll requested a review from azeey as a code owner October 8, 2024 14:48
@mjcarroll mjcarroll self-assigned this Oct 8, 2024
@mjcarroll mjcarroll merged commit c547c9b into gz-utils3 Oct 8, 2024
10 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/bzlmod branch October 8, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants