Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutdown explicitly while existing #623

Open
wants to merge 1 commit into
base: ros2
Choose a base branch
from
Open

Shutdown explicitly while existing #623

wants to merge 1 commit into from

Conversation

evshary
Copy link

@evshary evshary commented Oct 18, 2024

🦟 Bug fix

Summary

Shutdown explicitly after creating an entity.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@evshary
Shutdown explicitly while existing
1b031ec 
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
@evshary evshary requested a review from ahcorde as a code owner October 18, 2024 23:30
@evshary evshary mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde Awaiting requested review from ahcorde ahcorde is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Core development
Status: Inbox
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@evshary