Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider declare meter-kilogram-second units officially as part of the specification. #1385

Open
qingyouzhao opened this issue Mar 25, 2024 · 2 comments

Comments

@qingyouzhao
Copy link

qingyouzhao commented Mar 25, 2024

Context

In various documentations in the SDF spec, units kilograms, meters and seconds are used for different physical properties.
For example:

Problem

This created some ambiguity around inferring units:

  1. In places where units are not clearly stated, for example in geometry, should one assume all geometries are defined in meters?
  2. In a included mesh in mesh_shape, should one assume mesh vertex locations are in meters even if the included mesh file might have another unit convention. For example, FBX files have implied centimeters although it is stated as an unit-less format.

Proposal

Let's discuss options. There are a few options I can think of.

  1. Define units in a centralized place and only document exceptions in individual schemas. This is the simplest way to disambiguate if everyone has been working with this assumption.
  2. Define units explicitly as part of the schema similar to angle vs radians in pose. This would be more tedious to implement but makes units more explicit
@qingyouzhao qingyouzhao changed the title Consider declare meter-kilogram-second officially as part of the specification. Consider declare meter-kilogram-second units officially as part of the specification. Mar 25, 2024
@scpeters
Copy link
Member

scpeters commented Apr 1, 2024

Let's discuss options. There are a few options I can think of.

  1. Define units in a centralized place and only document exceptions in individual schemas. This is the simplest way to disambiguate if everyone has been working with this assumption.
  2. Define units explicitly as part of the schema similar to angle vs radians in pose. This would be more tedious to implement but makes units more explicit

I prefer option 1, and the we refer to ROS REP 103, which defines standard units for ROS.

@azeey
Copy link
Collaborator

azeey commented May 6, 2024

I'd prefer option 1 as well. I think for mesh files, the mesh loader should be implemented such that if the file format has a convention of using a different unit (e.g. centimeters), it would convert the values to meters during import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

No branches or pull requests

3 participants