Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a confirmation prompt when shutting down environment #40

Closed
gbolo opened this issue Jan 3, 2019 · 7 comments
Closed

add a confirmation prompt when shutting down environment #40

gbolo opened this issue Jan 3, 2019 · 7 comments
Assignees
Labels
release-3.2 tasks for release 3.2 web UI web UI

Comments

@gbolo
Copy link
Owner

gbolo commented Jan 3, 2019

Perhaps an "are you sure" prompt would help minimise possible accidental shutdowns of environments

@gbolo gbolo added web UI web UI release-3.2 tasks for release 3.2 labels Jan 3, 2019
@ahmedsajid
Copy link

Also entering environment name adds another level of sanity.

@gbolo
Copy link
Owner Author

gbolo commented Jan 3, 2019

Also entering environment name adds another level of sanity.

good point, but might be supper annoying typing it on a mobile. @kgeorgiou what do you think?

@dzhoou
Copy link
Collaborator

dzhoou commented Jan 4, 2019

I think showing the environment name on the dialog is good enough ("Are you sure to shut down environment X?")

@gbolo
Copy link
Owner Author

gbolo commented Jan 5, 2019

@dzhoou that sounds good

@kgeorgiou
Copy link
Collaborator

Yes, great idea 👍 I'll work on it.

@kgeorgiou kgeorgiou self-assigned this Jan 6, 2019
@gbolo
Copy link
Owner Author

gbolo commented Jan 14, 2019

@kgeorgiou you want this for release 3.2 or should we push this for release 3.3?

@kgeorgiou
Copy link
Collaborator

@gbolo 3.3. Unless I manage to open a PR by tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-3.2 tasks for release 3.2 web UI web UI
Projects
None yet
Development

No branches or pull requests

4 participants