Merging with main fork #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressed review feedback
…p into blobFunctional Conflicts: tests/WindowsAzureTests.php
…p into blobFunctional
Service Bus Delete Queue Implementation + Service Bus related Infrastructure improvement. The remaining issues have been tracked in github issues.
Conflicts: src/WindowsAzure/Services/Blob/Models/AccessCondition.php src/WindowsAzure/Services/Blob/Models/ContainerACL.php src/WindowsAzure/Services/Blob/Models/SourceAccessCondition.php tests/unit/WindowsAzure/Services/Blob/Models/AccessConditionTest.php tests/unit/WindowsAzure/Services/Blob/Models/ContainerACLTest.php tests/unit/WindowsAzure/Services/Blob/Models/GetContainerACLResultTest.php
Conflicts: src/WindowsAzure/Services/Blob/BlobRestProxy.php tests/WindowsAzureTests.php
Issue fixes
Apply code review Code Review: AliakB
Added unit test for new method arrayKeyExistsIgnoreCase
Refactor functional test base to be more robust
Blob get blob
Bug fixes Code Review: AliakB
Fix Azure#371 Code Review: AndreRod
Housekeeping: Fix minor code style issues.
Delete blob
Replacing the author headers to be the team contact information for consistency.
Replacing author header entries
Updating to team @author information
Fix @author tag Code Review: AndreRod, GongChen
Conflicts: WindowsAzure/Common/Internal/Resources.php WindowsAzure/Common/Internal/Serialization/XmlSerializer.php WindowsAzure/ServiceBus/Models/ActiveToken.php WindowsAzure/ServiceBus/ServiceBusRestProxy.php src/WindowsAzure.php tests/WindowsAzureTests.php tests/framework/ServiceBusRestProxyTestBase.php tests/unit/WindowsAzure/ServiceBus/ServiceBusRestProxyTest.php
|
LGTM |
ogail
pushed a commit
that referenced
this pull request
Jul 24, 2012
Add configuration for service bus using connection strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligning project structure so that we make sure serializers / etc are in sync