Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Caret/M-decode Operation #1695

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Add Caret/M-decode Operation #1695

merged 4 commits into from
Feb 13, 2024

Conversation

Kalkran
Copy link
Contributor

@Kalkran Kalkran commented Jan 26, 2024

Adds a Caret/M-decode operation.
This reverses the encoding that is done by (for example) cat [-v|--show-nonprinting], which is sometimes the only encoding option in limited environments.
Except for the gist linked in the source, there aren't really any easy ways to decode these strings.

@a3957273
Copy link
Member

Hey @Kalkran. Please can you add the test file to tests/operations/index.mjs, otherwise your tests don't actually run!

@a3957273
Copy link
Member

Also, when I merged in master, I messed up a comma in operations and can't seem to add it locally anymore. I think you might have turned off commits on your branch? You need to add a comma to src/core/config/Categories.json line 73.

@Kalkran
Copy link
Contributor Author

Kalkran commented Feb 13, 2024

Hey, thanks for having a look. I've added the comma and added the test to the index - also fixed the test now it actually runs. Should be ready to merge now.
I'm not sure if I turned off commits on my branch, it's a simple fork - but I have neglected to switch to a feature branch on my side so it's under master, that may be the issue.

@a3957273 a3957273 merged commit 14ee3f0 into gchq:master Feb 13, 2024
4 checks passed
@a3957273
Copy link
Member

Thanks, this change looks really useful! Wasn't a method I'd even heard of before, but given the ubiquity of cat can imagine it's a great data tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants