Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Date format in 'Parse X.509 certificate' #459

Merged
merged 3 commits into from Jan 1, 2019
Merged

Improve Date format in 'Parse X.509 certificate' #459

merged 3 commits into from Jan 1, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 30, 2018 •
edited by ghost
Loading

Fixes #420.

Reference RFC 5280 for interpreting century:

CAs ... MUST always encode certificate validity dates through the year 2049 as UTCTime
Certificate validity dates in 2050 or later MUST be encoded as GeneralizedTime

Edward Wall added 3 commits December 30, 2018 03:15
Update ParseX509Certificate.mjs
688c2d0
Update to understand Generalized / UTC Time
40acf75 
Future proofing for when certificates with dates after 2049 begin being issued.
These certificates' dates will be in Generalized Time not UTC Time as per RFC 5280
Simplify to improve readability
050ab03
@n1474335 n1474335 added the bug label Jan 1, 2019
@n1474335 n1474335 merged commit 050ab03 into gchq:master Jan 1, 2019
@n1474335
Copy link
Member

n1474335 commented Jan 1, 2019

Thanks very much for sorting this out.

This was referenced Dec 13, 2020
Open
Open
@ssmbct-netops ssmbct-netops mentioned this pull request Feb 12, 2021
Open
@SaFiSec SaFiSec mentioned this pull request Feb 13, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jan 21, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Feb 8, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Feb 16, 2022
Open
This was referenced Sep 26, 2022
Open
Open
Open
This was referenced Oct 6, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@n1474335