Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with gcc or clang passing
-std=c11
scanner.c fails to build (helix builds grammars with this argument):gcc:
clang:
It seems that
isascii
is deprecated and is not visible by default with-std=c11
. This PR attempts to address that although I'm not 100% sure it's the right fix. A better option might be to defineisascii
in this project if it's not already defined. Open to suggestions