Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some chunks not populated #4

Closed
Barteks2x opened this issue Mar 20, 2015 · 4 comments
Closed

Some chunks not populated #4

Barteks2x opened this issue Mar 20, 2015 · 4 comments

Comments

@Barteks2x
Copy link

Random lines of chunks are not populated. The issue is here. As I explaied in my comment to issue #2, you need to generate chunks at (x, z), (x+1, z), (x, z+1), (x+1, z+1). In any order.
The order doesn't matter because if you, for example, generate chunk at (x+1, z) it will also try to populate chunks at (x+1-1, z), (x+1, z-1), (x+1-1, z-1).
Your way mostly works because you don't explictly unload chunks. And apparently forge unloads them automatically. And when forge unloads chunks - some newly generated chunks won't be populated.

@gecgooden
Copy link
Owner

I have changed the chunks loaded to the ones you specified, and the test version is here: https://dl.dropboxusercontent.com/u/6295002/chunkgen-1.7.10-1.2.2.jar
It looks like it works to me, can you test and make sure it does for you?

@Barteks2x
Copy link
Author

It still doesn't seem to work correctly (tested with mcedit, generated 50x50 area). I decompiled the .jar file and I think I know why it dtill doesn't work correctly.
Before loading chunk you are checking if it's already loaded. But you only check if (x, z) is loaded, and then if it's not - generate chunks at (x+1, z), (x, z+1) and (x+1, z+1). So when you generate next chunk, (x+1, z), it will be already loaded. So it won't generate it again. And it won't generate chunks for population. The fix is to check existance of each chunk separately.

@gecgooden
Copy link
Owner

Ah, thats what I get for hastily coding..
This should do it: https://dl.dropboxusercontent.com/u/6295002/chunkgen-1.7.10-1.2.2b.jar

@Barteks2x
Copy link
Author

Works perfectly.

gecgooden added a commit that referenced this issue Mar 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants