Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider source data format #53

Open
geckon opened this issue Nov 20, 2020 · 1 comment
Open

Reconsider source data format #53

geckon opened this issue Nov 20, 2020 · 1 comment
Assignees
@geckon

Comments

@geckon
Copy link
Owner

geckon commented Nov 20, 2020

With #50 the source data are now parsed from StrictYAML format and dumped again as JSON for future parsing since JSON turns out to be much faster. It feels a little stupid though, so I should think about a better solution. It's not a pressing issue as the current solution works well and is fast enough. It's just technically not ideal.

StrictYAML offers type checking and subjectively easier editing than JSON but at the same time it's much much slower.

Action items:

  • Can I live without type checking? (then check plain YAML's speed)
  • Can I live with editing JSON? (then check speed of JSON parsing with validation)
  • Can I live with both of the above? (then use plain JSON?)
  • Is there any other (better) option?
@geckon geckon self-assigned this Nov 20, 2020
geckon added a commit that referenced this issue Nov 21, 2020
@geckon
Better file handling and added comments for future self (refs #50 #53)
10cf51e
@geckon
Copy link
Owner Author

geckon commented Nov 21, 2020 •
edited
Loading

Keep in mind, that JSON doesn't have comments... sigh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geckon geckon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@geckon