Added FATAL log message when an error is encountered when running the…

… sim (#2041)
genshinsim · Mar 11, 2024 · 0b93919 · 0b93919
1 parent 9a38abd
commit 0b93919
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/pkg/optimization/details.go b/pkg/optimization/details.go
@@ -87,7 +87,10 @@ func (stats *SubstatOptimizerDetails) calculateSubstatGradientsForChar(
 
 	seed := time.Now().UnixNano()
 	init := optstats.NewDamageAggBuffer(stats.simcfg)
-	optstats.RunWithConfigCustomStats(context.TODO(), stats.cfg, stats.simcfg, stats.gcsl, stats.simopt, seed, optstats.OptimizerDmgStat, init.Add)
+	_, err := optstats.RunWithConfigCustomStats(context.TODO(), stats.cfg, stats.simcfg, stats.gcsl, stats.simopt, seed, optstats.OptimizerDmgStat, init.Add)
+	if err != nil {
+		stats.optimizer.logger.Fatal(err.Error())
+	}
 	init.Flush()
 	// TODO: Test if median or mean gives better results
 	initialMean := mean(init.ExpectedDps)
@@ -99,7 +102,10 @@ func (stats *SubstatOptimizerDetails) calculateSubstatGradientsForChar(
 		stats.simcfg.Characters = stats.charProfilesCopy
 
 		a := optstats.NewDamageAggBuffer(stats.simcfg)
-		optstats.RunWithConfigCustomStats(context.TODO(), stats.cfg, stats.simcfg, stats.gcsl, stats.simopt, seed, optstats.OptimizerDmgStat, a.Add)
+		_, err := optstats.RunWithConfigCustomStats(context.TODO(), stats.cfg, stats.simcfg, stats.gcsl, stats.simopt, seed, optstats.OptimizerDmgStat, a.Add)
+		if err != nil {
+			stats.optimizer.logger.Fatal(err.Error())
+		}
 		a.Flush()
 
 		substatGradients[idxSubstat] = mean(a.ExpectedDps) - initialMean

diff --git a/pkg/optimization/opt_energy.go b/pkg/optimization/opt_energy.go
@@ -80,7 +80,10 @@ func (stats *SubstatOptimizerDetails) findOptimalERforChars() {
 
 	seed := time.Now().UnixNano()
 	a := optstats.NewEnergyAggBuffer(stats.simcfg)
-	optstats.RunWithConfigCustomStats(context.TODO(), stats.cfg, stats.simcfg, stats.gcsl, stats.simopt, seed, optstats.OptimizerERStat, a.Add)
+	_, err := optstats.RunWithConfigCustomStats(context.TODO(), stats.cfg, stats.simcfg, stats.gcsl, stats.simopt, seed, optstats.OptimizerERStat, a.Add)
+	if err != nil {
+		stats.optimizer.logger.Fatal(err.Error())
+	}
 	a.Flush()
 	for idxChar := range stats.charProfilesERBaseline {
 		// erDiff is the amount of ER we need