Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of Baron Bunny as a gadget #1399

Merged
merged 6 commits into from
Aug 3, 2023

Conversation

Charlie-Zheng
Copy link
Contributor

@Charlie-Zheng Charlie-Zheng commented Jun 27, 2023

Closes #1282

@Charlie-Zheng Charlie-Zheng marked this pull request as draft June 27, 2023 12:51
@Charlie-Zheng Charlie-Zheng marked this pull request as ready for review June 27, 2023 14:50
@Charlie-Zheng
Copy link
Contributor Author

Note: I found no sources showing that Baron Bunny interactions with Sucrose/Faruzan skill are 50 gauge? I already found some inaccuracies in the original issue, so I'm awaiting further confirmation of this feature

internal/characters/amber/bunny.go Show resolved Hide resolved
internal/characters/amber/bunny.go Show resolved Hide resolved
internal/characters/amber/bunny.go Show resolved Hide resolved
internal/characters/amber/bunny.go Show resolved Hide resolved
internal/characters/amber/bunny.go Show resolved Hide resolved
internal/characters/amber/bunny.go Outdated Show resolved Hide resolved
internal/characters/amber/bunny.go Outdated Show resolved Hide resolved
internal/characters/amber/bunny.go Outdated Show resolved Hide resolved
internal/characters/amber/bunny.go Outdated Show resolved Hide resolved
internal/characters/amber/bunny.go Outdated Show resolved Hide resolved
@k0l11 k0l11 added kind: enhancement New feature or request area: internal Related to artifacts/weapons/characters kind: game alignment Missing mechanic from the game and removed kind: enhancement New feature or request labels Jul 4, 2023
@k0l11 k0l11 merged commit 9bd4afe into genshinsim:main Aug 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: internal Related to artifacts/weapons/characters kind: game alignment Missing mechanic from the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amber's Baron Bunny should be implemented as a Gadget
2 participants