Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor char actions to return error #1720

Merged
merged 77 commits into from
Sep 23, 2023

Conversation

srliao
Copy link
Contributor

@srliao srliao commented Sep 23, 2023

  • allow char actions to properly return error if needed (instead of currently panicking in the rare case)
  • add automate test to use each ability once for each char to catch unexpected panics
  • add default "implementation" for all actions to template to avoid stack overflow and give proper error msg
  • fixed a wanderer bug that got caught coincidentally....

@srliao srliao merged commit 508d4b9 into genshinsim:main Sep 23, 2023
3 checks passed
@srliao srliao deleted the srl-2023-09-22-unimplemented-checks branch September 23, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant