character plunge frames/attack implementation - airborne from xianyun

[Charlie-Zheng]

• albedo
• alhaitham
• ayaka
• ayato
• barbara
• bennett
• charlotte
• cyno (out/in q state)
• dehya
• diluc
• dori
• eula
• freminet
• furina
• gaming not in this pr
• heizou
• hu tao (out/in e state)
• itto
• kaveh
• kazuha
• keqing
• klee
• lynette
• navia
• noelle
• raiden (out/in q state)
• sucrose
• wriothesley
• xiangling
• xianyun
• xiao (out/in q state)
• yae
• yanfei

[srliao]

In addition to my comment re setting status, every jump action should also probably return an error (and therefore ending the sim) if already airborne (i.e. jump, jump should crash the sim).

This is because if we don't simulate slow falling to ground, then you can't jump again while in mid air

should be request change not approved

[Charlie-Zheng]

In addition to my comment re setting status, every jump action should also probably return an error (and therefore ending the sim) if already airborne (i.e. jump, jump should crash the sim).

This is because if we don't simulate slow falling to ground, then you can't jump again while in mid air

Hmm I thought this would be like globally applied to all characters (no actions except plunge can be done while airborne), and it's up to the individual characters to override allowing actions while airborne (like Kazuha/Xiao E being able to be tapped while airborne)

[srliao]

In addition to my comment re setting status, every jump action should also probably return an error (and therefore ending the sim) if already airborne (i.e. jump, jump should crash the sim).

This is because if we don't simulate slow falling to ground, then you can't jump again while in mid air

retracted. already handled here. i forgot

gcsim/pkg/core/player/exec.go

Lines 127 to 129 in cb8fccb

	if h.airborne != Grounded && t != action.ActionLowPlunge && t != action.ActionHighPlunge {
	return ErrInvalidAirborneAction
	}