Rewrite Calamity Queller #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srliao
reviewed
Feb 3, 2022
| expiry = c.F + 60*20 | ||
|
|
||
| return false | ||
| }, fmt.Sprintf("calamity-queller-%v", char.Name())) | ||
|
|
||
| char.AddMod(core.CharStatMod{ |
There was a problem hiding this comment.
it's probably best if this AddMod gets moved into the Subscribe event with a proper expiry set. We're trying to clean up a bit and avoid using -1 (which is just laziness on my part). See #203
There was a problem hiding this comment.
i think the AddMod will have to stay because the Ele% is permanent buff.
unless i am missing something here or you meant the ATK buff...
i could try moving the ATK buff inside the event but don't know if i can do that while keeping stacks from previous cast.
There was a problem hiding this comment.
Oh sorry you're right. Let me think about this for a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.