Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix print legend visibility issues #708

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

theduckylittle
Copy link
Member

  1. Adds check to ensure min/maxresolution are in range when
    specified.
  2. Adds a check to ensure the legend has not been turned off in the
    catalog.

refs: #706

@chughes-lincoln
Copy link
Contributor

This makes my print legends look so much better already!

A couple of notes:

  1. It correctly honors legends being set to false in the catalog
  2. It doesn't seem to honor scale based legends in the catalog or the print out (not a new issue in the catalog, I believe that's how it already was)

An example for 2: I have a contours dataset with 40ft and 10ft contours grouped into the same map-source. At the full extent and scale of my map neither of them show up in the map, but they do show up as white space in the catalog legend and the print legend. If I zoom in a bit the 40ft contours appear, including the legend. At this scale there's some white space in the catalog and print legends due to the 10ft contours. If I zoom in further the 10ft contours replace the 40ft contours, and I now see some white space in the catalog and print legends due to the 40ft contours.

1. Adds check to ensure min/maxresolution are in range when
   specified.
2. Adds a check to ensure the legend has not been turned off in the
   catalog.

refs: geomoose#706
@klassenjs klassenjs merged commit 5591ce3 into geomoose:main Mar 18, 2022
@klassenjs klassenjs added this to the 3.8.1/3.9 milestone Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants