Limit the number of bufferable features #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a clean way we could tell the user why the buffer button is disabled? |
|
Could put a message on the bottom. Would need to translate that message to our various languages 😬 |
|
Think it is worth it or just merge it? As is it could just look broke without saying what could fix it. Although that is still better than crashing. Other than that, the PR does what it says on the tin. |
The browser can only handle so much, limit the number of features GeoMoose willingly buffers from the results. refs: geomoose#711
|
I think that things like this do well being very interactive. Allow people
to hit the button but the first thing is a check with a very obvious
message, "Buffer limit of # exceeded"
…On Thu, Mar 17, 2022 at 8:24 PM Jim Klassen ***@***.***> wrote:
Think it is worth it or just merge it? As is it could just look broke
without saying what could fix it. Although that is still better than
crashing.
—
Reply to this email directly, view it on GitHub
<#715 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABIE7GVI7KUQILQC5BUFJV3VAPZQRANCNFSM5RAVEYWQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
theduckylittle
force-pushed
the
feature/limit-buffer-features
branch
from
8688d0a
to
cd3e3ea
Compare
|
Yeah... I'm sympathetic to giving the user too much information. I've updated this to show a modal when there are too many features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The browser can only handle so much, limit the number of
features GeoMoose willingly buffers from the results.
refs: #711