Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#219] Add support for AdminRules to Rest Batch services - [#221] Add RuleLimits handling to Rule REST endpoint #220

Open
wants to merge 3 commits into
base: 3.5.x
Choose a base branch
from
Open

[#219] Add support for AdminRules to Rest Batch services - [#221] Add RuleLimits handling to Rule REST endpoint #220

wants to merge 3 commits into from

Conversation

taba90
Copy link
Contributor

@taba90 taba90 commented Jul 14, 2022

No description provided.

@taba90 taba90 force-pushed the 219-multiple-rules-insertion branch from 9bc6165 to db51edd Compare July 14, 2022 08:44
@taba90 taba90 changed the title [#219] GeoFence - Inserting multiple GeoFence rules together [#219] Allow Insertion of multiple Rules and Admin Rule via Rest Jul 14, 2022
etj
etj requested changes Jul 14, 2022
View reviewed changes
Copy link
Member

@etj etj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taba90 I'd rather not merge this code.
The existing batch operation already allows for insert/delete/update of rules, users, groups, etc.
Please read the comment in the original #219 issue.

@taba90 taba90 force-pushed the 219-multiple-rules-insertion branch from db51edd to e9ffad5 Compare July 15, 2022 16:01
@taba90 taba90 force-pushed the 219-multiple-rules-insertion branch from e9ffad5 to 648e2bf Compare July 18, 2022 07:55
@taba90 taba90 changed the title [#219] Allow Insertion of multiple Rules and Admin Rule via Rest [#219] Add support for AdminRules to Rest Batch services - [#221] Add RuleLimits handling to Rule REST endpoint Jul 18, 2022
etj
etj reviewed Aug 29, 2022
View reviewed changes
...s/rest/impl/src/main/java/org/geoserver/geofence/services/rest/impl/RESTRuleServiceImpl.java Outdated
@@ -88,7 +93,6 @@ public RESTOutputRule get(Long id) throws BadRequestRestEx, NotFoundRestEx, Inte
}

@Override
@Transactional(propagation = Propagation.REQUIRED, value = "geofenceTransactionManager")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not remove the Transactional annotation here: there are many db calls and race conditions may disrupt the priority handling.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@taba90
Copy link
Contributor Author

taba90 commented Aug 29, 2022

thanks for your review @etj. Your feedback have been applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etj etj etj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taba90 @etj