Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writer Toolbar un-reachable for fields with very long copy #6021

Closed
ovenum opened this issue Nov 29, 2023 · 4 comments · Fixed by #6023
Closed

Writer Toolbar un-reachable for fields with very long copy #6021

ovenum opened this issue Nov 29, 2023 · 4 comments · Fixed by #6023
Assignees
Labels
type: bug 🐛 Is a bug; fixes a bug
Milestone

Comments

@ovenum
Copy link
Contributor

ovenum commented Nov 29, 2023

Description

When the Writer Field toolbar is not inline, the toolbar will become unreachable in long textfields that are taler than the screen height.

Expected behavior
The Toolbar to be always reachable/ usable

To reproduce

Create a Writer Field with

toolbar:
  inline: false

Add looong copy text so that the field height is higher than the screen height. Scroll down to edit text at the bottom of the field. The writer toolbar will not be visible anymore.

Your setup

Kirby Version
4.0

@distantnative
Copy link
Member

It should be sticky when the field has focus. Will need to check this later, if a general problem or something more specific in your setup.

@ovenum
Copy link
Contributor Author

ovenum commented Nov 29, 2023

Thanks for looking into this. Just re-checked the issue.
The writer field is contained inside a blocks field. Focusing the writer field and scrolling will not make the toolbar sticky. I also checked by hiding the k-page-view-header component with dev-tools.

@distantnative
Copy link
Member

Are you sure about the last part?
Can reproduce the general issue, but when I lower the opacity of the page header, I can see the toolbar hiding beneath:
Screenshot 2023-11-29 at 23 00 50

Note: the issue seems to be that also for inline: false there are top/left style values set on the toolbar, overwriting the sticky top offset.

@ovenum
Copy link
Contributor Author

ovenum commented Nov 29, 2023

Sorry Nico! Should have supplied a proper reproducible example when creating the issue.

The toolbar will become sticky when the writer field is inside the first block (hidden behind the k-page-view-header).
It will not become sticky when it’s not inside the first block.

Hope it’s reproducible now.

UPDATE
It’s exactly as you described. I mixed up Block Field focus and Writer Field focus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants