Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming any file results in "The name must not be empty" #6024

Closed
mit-stauffer opened this issue Nov 29, 2023 · 1 comment · Fixed by #6027
Closed

Renaming any file results in "The name must not be empty" #6024

mit-stauffer opened this issue Nov 29, 2023 · 1 comment · Fixed by #6027
Assignees
Labels
critical: roadblock 🚧 Needs to be solved first type: regression 🚨 Is a regression between versions
Milestone

Comments

@mit-stauffer
Copy link

Description

I cannot rename ANY files in 4.0.0
When I click rename the dialog appears, but instead of the name it has only a dash in it.

grafik

After inserting any name I get this error:

grafik

To reproduce

Install Kirby 4.0.0 Starterkit on Apache 2 with PHP 8.1 or 8.2.12

  • I tried it on a local XAMPP on Windows with Apache 2 and PHP 8.1 and a remote server with Apache 2 and PHP 8.2.12
  • All requirements are met (https://getkirby.com/docs/guide/quickstart#requirements)
  • I had this in 2 client sites I tried to upgrade as well as in the Kirby starterkit
  • It doesn't matter what filetype or if it's an existing or recently uploaded file (I can upload and delete, just renaming is faulty)
  • I can also set different name during a first upload of a file, but after that, its faulty
@distantnative distantnative added this to the 4.0.1 milestone Nov 29, 2023
@distantnative distantnative added type: bug 🐛 Is a bug; fixes a bug type: regression 🚨 Is a regression between versions critical: roadblock 🚧 Needs to be solved first and removed type: bug 🐛 Is a bug; fixes a bug labels Nov 29, 2023
@distantnative
Copy link
Member

@mit-stauffer I'm sorry we missed this regression, we will try to have a patch out soon.

Until then, you should be able to fix this problem by changing the line https://github.com/getkirby/kirby/blob/main/config/areas/files/dialogs.php#L29 to

'allow'     => 'a-z0-9@._-',

distantnative added a commit that referenced this issue Nov 30, 2023
@distantnative distantnative self-assigned this Nov 30, 2023
@distantnative distantnative linked a pull request Nov 30, 2023 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical: roadblock 🚧 Needs to be solved first type: regression 🚨 Is a regression between versions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants