Feat: Allow MacOS menubar icon height to be overridden #280
+46
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented via functional options, so as to be backwards-compatible for existing importers. Allow the height of the menubar icon on MacOS to be set, scaling the input image proportionally to avoid any kind of squish effect. The default size of 16x16 is fine, but it can be nice to use up a little more space with a 22-height icon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented via functional options, so as to be backwards-compatible for existing importers.
Allow the height of the menubar icon on MacOS to be set, scaling the input image proportionally to avoid
any kind of squish effect.
The default size of 16x16 is fine, but it can be
nice to use up a little more space with a 22-height icon.
Example with default(16) and custom (22) heights:
