Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step Function - Add support for State Machine to resourcegrouptaggingapi #8215

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

zkarpinski
Copy link
Contributor

resolves #8212

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.53%. Comparing base (43410b9) to head (c2cc710).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
moto/resourcegroupstaggingapi/models.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8215      +/-   ##
==========================================
- Coverage   94.53%   94.53%   -0.01%     
==========================================
  Files        1155     1157       +2     
  Lines       99707    99941     +234     
==========================================
+ Hits        94261    94481     +220     
- Misses       5446     5460      +14     
Flag Coverage Δ
servertests 28.81% <60.00%> (-0.04%) ⬇️
unittests 94.50% <90.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bblommers bblommers added this to the 5.0.17 milestone Oct 10, 2024
@bblommers bblommers merged commit 84cac7a into getmoto:master Oct 10, 2024
53 checks passed
@zkarpinski zkarpinski deleted the sfn-tagging branch October 10, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Add Step Functions to support resourcegroupstagging
2 participants