Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legacy plugin loading for packages #2813

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Conversation

avaris
Copy link
Member

@avaris avaris commented Oct 19, 2020

Resolves: #2805

  • Resolves packages for legacy plugins (i.e. "foo.bar") and adds tests for it
  • Restores pelican.signals but it will raise an ImportError. So, plugins using import pelican.signals directly will see this:

    Importing from pelican.signals is deprecated. Use from pelican import signals or import pelican.plugins.signals instead.


  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
    Updated documentation for changed code

Updated legacy plugin loader to handle pakcages if the PLUGINS entry
contains `.`. Also adds a test for it.
@justinmayer
Copy link
Member

Really appreciate you taking the time to work on solutions for these issues. You rock! 🥇

@justinmayer justinmayer merged commit f4bb0d8 into getpelican:master Oct 19, 2020
@avaris avaris deleted the 2805 branch October 19, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document breaking changes in Pelican 4.5
2 participants