Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add categories.html template to default theme. Fixes #2972 #2973

Merged

Conversation

pauloxnet
Copy link
Member

@pauloxnet pauloxnet commented Jan 12, 2022

Pull Request Checklist

Resolves: #2972

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • Updated documentation for changed code

@pauloxnet
Copy link
Member Author

Tests failure seems unrelated to the commit.

@justinmayer
Copy link
Member

Hi Paolo. 👋 It seems to me that the test failure is happening because the functional test output was not updated to match the changes in this PR. Did you follow all the steps in the Development section of the docs?

@pauloxnet
Copy link
Member Author

Thanks for the feedback. I'll check it again tomorrow.

@pauloxnet
Copy link
Member Author

@justinmayer thanks again for the feedback. I updated some test to match the fixed categories template. Now all tests pass.

@pauloxnet
Copy link
Member Author

Can some mantainer review and merge or close this PR ?

@justinmayer
Copy link
Member

@pauloxnet: Thank you for updating the functional test output.

@getpelican/reviewers: Any final comments on this pull request before it is merged?

@justinmayer justinmayer changed the title Fix #2972 Add notmyidea categories.html template Add notmyidea categories.html template. Fix #2972 Feb 1, 2022
@justinmayer justinmayer changed the title Add notmyidea categories.html template. Fix #2972 Add categories.html template to default theme. Fixes #2972 Feb 1, 2022
@justinmayer
Copy link
Member

Many thanks for the enhancement, Paolo! On a side note, for most contributions to Pelican, you can omit filing an issue + PR and instead simply submit a PR by itself. One less thing to keep track of. 😊

@justinmayer justinmayer merged commit 2f5fc10 into getpelican:master Feb 1, 2022
@pauloxnet pauloxnet deleted the feature/2972-categories-notmyidea branch November 12, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Categories template missing in notmyidea theme
2 participants