Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reference parameter to the install command #1896

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Added reference parameter to the install command #1896

merged 1 commit into from
Apr 8, 2022

Conversation

aguywithcode
Copy link
Contributor

When running the command as originally given

>porter install --cred github

The following output results

Error: No bundle specified. Either an installation name, --reference, --file or --cnab-file must be specified or the current directory must contain a porter.yaml file.

What does this change

Give a summary of the change, and how it affects end-users. It's okay to copy/paste your commit messages.

For example if it introduces a new command or modifies a commands output, give an example of you running the command and showing real output here.

What issue does it fix

Closes # (issue)

If there is not an existing issue, please make sure we have context on why this change is needed. See our Contributing Guide for examples of when an existing issue isn't necessary.

Notes for the reviewer

Put any questions or notes for the reviewer here.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh gosh I just realized that both quickstarts have the same problem (both on the main website and v1). Thanks for the patch!

@carolynvs
Copy link
Member

@aguywithcode Your commit needs to be signed before I can merge this PR. Here's a link explaining how to fix your commit so that it is signed and satisfies our Developer Certificate of Origin (DCO).

https://github.com/getporter/porter/blob/main/CONTRIBUTING.md#signing-your-commits

@aguywithcode
Copy link
Contributor Author

@aguywithcode Your commit needs to be signed before I can merge this PR. Here's a link explaining how to fix your commit so that it is signed and satisfies our Developer Certificate of Origin (DCO).

https://github.com/getporter/porter/blob/main/CONTRIBUTING.md#signing-your-commits

Ahh, I saw this after I made the pull request. Also saw that the other install command in the tutorial has the same problem. I'll follow the steps for DCO signing.

@carolynvs
Copy link
Member

@aguywithcode I see another merge commit on the PR now but the original commit isn't signed yet. If you run into trouble with the git commands to sign your commit let me know and I'll try to help!

@carolynvs carolynvs self-assigned this Feb 20, 2022
Signed-off-by: Michael Brown <micbrown@microsoft.com>
@carolynvs
Copy link
Member

Thanks for contributing the fix and sorry for all the extra effort getting that commit signed. 💖

@carolynvs carolynvs merged commit dc24a06 into getporter:main Apr 8, 2022
@carolynvs carolynvs mentioned this pull request May 25, 2022
@aguywithcode aguywithcode deleted the patch-1 branch June 24, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants