Move examples into example-bundles repository #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the example bundles in /examples/ and point to the relocated example bundles in https://github.com/getporter/example-bundles Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Now that the examples are moved into example-bundles, remove targets for building and publishing example bundles from Porter's build. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run test-porter-release |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
carolynvs
force-pushed
the
move-examples
branch
from
bac1e2b
to
a2a7676
Compare
|
/azp run test-porter-release |
|
Azure Pipelines successfully started running 1 pipeline(s). |
The example bundles were moved to github.com/getporter/examples, and are now published to ghcr.io/getporter/examples/NAME. The version number of most bundles was bumped as well to avoid confusing with existing bundles. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
move-examples
branch
from
a2a7676
to
2f8aa33
Compare
vdice
approved these changes
Apr 14, 2022
|
Thanks for the review on this chonkin' PR! 💖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Remove the example bundles in /examples/ and point to the relocated example bundles in https://github.com/getporter/examples
What issue does it fix
N/A
Notes for the reviewer
It's not as awful to review as it looks, it's mostly deletes. 💥
Checklist
Reviewer Checklist