Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid updating query result for archived queries #6488

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Avoid updating query result for archived queries #6488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Avoid updating query result for archived queries
  • Loading branch information
@eradman
eradman committed Sep 28, 2023
commit aa6650ac8966873cb5138f9ade94b1f79cbde802
1 change: 1 addition & 0 deletions redash/models/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,6 +738,7 @@ def update_latest_result(cls, query_result):
queries = Query.query.filter(
Query.query_hash == query_result.query_hash,
Query.data_source == query_result.data_source,
Query.is_archived.is_(False),
)

for q in queries:
Expand Down
4 changes: 2 additions & 2 deletions tests/models/test_queries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ def setUp(self):
def test_updates_existing_queries(self):
query1 = self.factory.create_query(query_text=self.query)
query2 = self.factory.create_query(query_text=self.query)
query3 = self.factory.create_query(query_text=self.query)
query3 = self.factory.create_query(query_text=self.query, is_archived=True)

query_result = QueryResult.store_result(
self.data_source.org_id,
Expand All @@ -478,7 +478,7 @@ def test_updates_existing_queries(self):

self.assertEqual(query1.latest_query_data, query_result)
self.assertEqual(query2.latest_query_data, query_result)
self.assertEqual(query3.latest_query_data, query_result)
self.assertEqual(query3.latest_query_data, None)

def test_doesnt_update_queries_with_different_hash(self):
query1 = self.factory.create_query(query_text=self.query)
Expand Down
Loading