Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigger textarea for query description #6518

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Bigger textarea for query description #6518

merged 2 commits into from
Oct 13, 2023

Conversation

deathvulture
Copy link
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

This PR tries to create a better user experience by modifying the way the textarea component behaves while editing the query description in the Query Source page.
This should help with this Issue #6434

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Tested on Chrome and Firefox with different resolutions to check that the UI doesn't break on edge cases.

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

query_description.mp4

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #6518 (f98445f) into master (abbd4d3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6518   +/-   ##
=======================================
  Coverage   61.26%   61.26%           
=======================================
  Files         158      158           
  Lines       12889    12889           
  Branches     1755     1755           
=======================================
  Hits         7896     7896           
  Misses       4743     4743           
  Partials      250      250           

@justinclift justinclift merged commit eafe30d into getredash:master Oct 13, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants