Allow Query.options to be None

[eradman]

Query.options may not have a value on a database created by 10.1.0

What type of PR is this?

• Bug Fix

Description

This incompatibility was introduced in #4797

How is this tested?

• Unit tests (pytest, jest)
• Manually

[codecov]

Codecov Report

Merging #6519 (1a3d0de) into master (eafe30d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #6519   +/-   ##
=======================================
  Coverage   61.26%   61.26%           
=======================================
  Files         158      158           
  Lines       12889    12889           
  Branches     1755     1755           
=======================================
  Hits         7896     7896           
  Misses       4743     4743           
  Partials      250      250           

Files	Coverage Δ
redash/models/__init__.py	92.25% <100.00%> (ø)

[justinclift]

This incompatibility was introduced in #5751

Is that the correct PR number?

Looking at that PR just now, it seems like it was closed without being merged. (?)

[eradman]

Ah right, updated the PR

[justinclift]

Ah right, updated the PR

Thanks, that seems like the right one now. 😄

[justinclift]

@eradman If you reckon this is ready to merge, then I'm happy to do so. 😄

[eradman]

This seems good in my testing. With this patch I have succussfuly upgraded Redash with queries created by 10.1.0

[justinclift]

Cool, lets merge this then. 😄

[eradman]

Appologies, somehow I managed to update this PR with the fix for the counter widget as well (#6521)

We can revert this, or leave it as is and confirm that this fixes the problem

[justinclift]

Ahhh, damn. We've subsequently merged other PRs too, so not super clean to revert.

Are you ok to check if the accidentally-included-fix does solve the counter widget problem?

If it does, then we got lucky. 😁

If not though, then figuring out the proper fix for the counter widget issue (#6521) and getting it merged there is probably the right approach. Hopefully. 😄

[eradman]

The counter widget fix (1a3d0de) is working well for me. I'll respond to any feedback in #6521