Remove pygridgain so Trino data source shows up #6546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also updates the python tzlocal dependency to the 4.x series, as seems to be required for Trino to work.
Codecov Report
@@ Coverage Diff @@
## master #6546 +/- ##
==========================================
+ Coverage 61.89% 61.90% +0.01%
==========================================
Files 158 158
Lines 12966 12966
Branches 1773 1773
==========================================
+ Hits 8025 8027 +2
+ Misses 4666 4664 -2
Partials 275 275 |
guidopetri
approved these changes
Oct 23, 2023
|
Thanks @justinclift :) |
|
You're welcome, thanks for merging it @guidopetri. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
This PR updates some dependency pieces so that Trino shows up in the data sources list again.
tzlocaldependency to the 4.x series, as seems to be required for Trino to workpygridgaindependency, as that has a hard dependency ontzlocal2.1 and therefore breaks TrinoHow is this tested?
With a newly built docker container on my local pc, I confirmed that the Trino data source is not available without this PR, but is available after this PR is applied.
Related Tickets & Documents