fix(publish): Fix error when special target 'all' is used

Fixes #141, follow up to #137 where there was a forgotten negation causing this issue. Tests will follow in a separate PR.
getsentry · Dec 1, 2020 · 2ef4443 · 2ef4443
1 parent 2fb243b
commit 2ef4443
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.13.4
+
+- fix(publish): Fix error when special target 'all' is used
+
 ## 0.13.3
 
 - fix(publish): Only allow valid target ids for -t (#137)

diff --git a/src/commands/publish.ts b/src/commands/publish.ts
@@ -470,14 +470,14 @@ export async function publishMain(argv: PublishOptions): Promise<any> {
 
   let targetConfigList = config.targets || [];
 
-  if (targetList.has(SpecialTarget.All)) {
+  if (!targetList.has(SpecialTarget.All)) {
     targetConfigList = targetConfigList.filter(targetConf =>
       targetList.has(getTargetId(targetConf))
     );
   }
 
   if (!targetList.has(SpecialTarget.None)) {
-    if (!targetConfigList.length) {
+    if (targetConfigList.length === 0) {
       logger.warn('No valid targets detected! Exiting.');
       return undefined;
     }