Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: allow urllib3>=1.25.10 #659

Merged
merged 1 commit into from
Jul 31, 2023
Merged

chore: allow urllib3>=1.25.10 #659

merged 1 commit into from
Jul 31, 2023

Conversation

JohnVillalovos
Copy link
Contributor

Allow use of urllib3>=1.25.10. By default it will use urllib3>=2 as that is the latest version. But this will allow people to pin urllib3<2 and still use the latest version of requests and responses.

Closes: #657

@JohnVillalovos JohnVillalovos mentioned this pull request Jul 28, 2023
Closed
markstory
markstory reviewed Jul 28, 2023
View reviewed changes
setup.py Outdated
@@ -18,7 +18,7 @@

install_requires = [
"requests>=2.30.0,<3.0",
"urllib3>=2.0.0,<3.0",
"urllib3>=1.25.10",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"urllib3>=1.25.10",
"urllib3>=1.25.10,<3.0",

We should keep the upper bound. Future versions of urllib3 may require changes in responses.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Done.

@codecov
Copy link

codecov bot commented Jul 28, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (78854ab) 100.00% compared to head (b5ed6ee) 100.00%.

❗ Current head b5ed6ee differs from pull request most recent head 7ab8732. Consider uploading reports for the commit 7ab8732 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #659   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines         2875      2875           
=========================================
  Hits          2875      2875

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beliaev-maksim
Copy link
Collaborator

please add a matrix of tests in CI. We need to test on both 1.x and 2.x

otherwise we give a promise that we cannot guarantee

@JohnVillalovos
Copy link
Contributor Author

please add a matrix of tests in CI. We need to test on both 1.x and 2.x

otherwise we give a promise that we cannot guarantee

Thanks.

Done, I think. The CI doesn't run for me yet so I'm not 100% certain.

@JohnVillalovos
Copy link
Contributor Author

JohnVillalovos commented Jul 28, 2023 •
edited
Loading

@beliaev-maksim or @markstory Can one of you enable the workflows to run? Thanks.

@JohnVillalovos
chore: allow urllib3>=1.25.10
7ab8732 
Allow use of urllib3>=1.25.10. By default it will use urllib3>=2 as
that is the latest version. But this will allow people to pin
urllib3<2 and still use the latest version of requests and responses.

Closes: #657
@JohnVillalovos
Copy link
Contributor Author

Done, I think. The CI doesn't run for me yet so I'm not 100% certain.

I was able to run the CI over in my fork. And I got the tests to pass. https://github.com/JohnVillalovos/responses/pull/2

@AD-Wright AD-Wright mentioned this pull request Jul 29, 2023
Closed
@JohnVillalovos JohnVillalovos mentioned this pull request Jul 31, 2023
Closed
@markstory markstory linked an issue Jul 31, 2023 that may be closed by this pull request
responses==0.23.2 breaks pip resolution with popular packages #654
Closed
@markstory markstory merged commit c226971 into getsentry:master Jul 31, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markstory markstory markstory left review comments

@Seluj78 Seluj78 Seluj78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overly strict version constraint on urllib3 responses==0.23.2 breaks pip resolution with popular packages
4 participants
@JohnVillalovos @beliaev-maksim @markstory @Seluj78