Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POTEL 19 - Review feedback #3491

Merged
merged 77 commits into from
Jun 24, 2024
Merged

POTEL 19 - Review feedback #3491

merged 77 commits into from
Jun 24, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Jun 17, 2024

#skip-changelog

📜 Description

Changes requested in previous PR reviews as well as TODOs in code.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

adinauer and others added 30 commits March 27, 2024 16:30
Copy link
Contributor

github-actions bot commented Jun 17, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 2c0eddd

Copy link
Contributor

github-actions bot commented Jun 17, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 386.83 ms 468.12 ms 81.30 ms
Size 1.70 MiB 2.28 MiB 596.98 KiB

Baseline results on branch: feat/potel-18-use-correct-options-for-client-ctor

Startup times

Revision Plain With Sentry Diff
20cae9f 386.23 ms 450.61 ms 64.38 ms

App size

Revision Plain With Sentry Diff
20cae9f 1.70 MiB 2.28 MiB 596.88 KiB

Previous results on branch: feat/potel-19-pr-review-feedback

Startup times

Revision Plain With Sentry Diff
0bb901c 422.57 ms 473.80 ms 51.22 ms

App size

Revision Plain With Sentry Diff
0bb901c 1.70 MiB 2.28 MiB 596.95 KiB

Base automatically changed from feat/potel-18-use-correct-options-for-client-ctor to 8.x.x June 24, 2024 12:11
@adinauer adinauer merged commit 54e6568 into 8.x.x Jun 24, 2024
2 of 21 checks passed
@adinauer adinauer deleted the feat/potel-19-pr-review-feedback branch June 24, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants