Fix missing sentryMonitor macro when command is called outside the CLI environment
#812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stayallive
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
This is a awkward situation but I guess it's not the worst. Been thinking if there was another way we could better fix this. I guess we would need a bootWhenNotApplicable or something otherwise. But since the inactive version only adds a simple closure to an array this is fine for now. Thanks!
stayallive
changed the title
sentryMonitor macro when command is called outside the CLI environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to fix the problem described by the #805 issue.
The problem is that whenever an artisan command is called when not running in console, the schedule method on the ConsoleKernel is executed.
This happens on Laravel Vapor, for example, where the config is cached on the fly with
$app->make(ConsoleKernelContract::class)->call('config:cache');invendor/laravel/vapor-core/stubs/fpmRuntime.phpthis can be replicated easily, by doing
Artisan::call('inspire');in a controller.