Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement notifications tracing and breadcrumbs #852

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

stayallive
Copy link
Collaborator

@stayallive stayallive commented Feb 9, 2024

This implements (partially) #625.

Laravel also has a Illuminate\Notifications\Events\NotificationFailed, however this event is actually unused because when a notification fails to sent it just throws an exception from the underlying transport. So no need to handle this event.

@stayallive stayallive self-assigned this Feb 9, 2024
@stayallive stayallive marked this pull request as draft February 9, 2024 16:52
@stayallive
Copy link
Collaborator Author

Seems like I do not to investigate a bit why tests are reporting so many errors on Laravel 9 and below (don't think the code is wrong but something in the tests).

@stayallive stayallive marked this pull request as ready for review April 9, 2024 08:06
Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs and :shipit:

@stayallive
Copy link
Collaborator Author

@stayallive stayallive merged commit 1b045d5 into master Apr 11, 2024
24 checks passed
@stayallive stayallive deleted the add-notifications-integration branch April 11, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants