Skip to content

Commit

Permalink
Fix PHP 7.2 - 7.3 tests
Browse files Browse the repository at this point in the history
  • Loading branch information
cleptric committed Sep 20, 2023
1 parent bf9ed6d commit e955aae
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 8 deletions.
17 changes: 13 additions & 4 deletions src/HttpClient/HttpClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,20 @@

class HttpClient implements HttpClientInterface
{
protected Options $options;
/**
* @var Options
*/
protected $options;

protected string $sdkIdentifier;
/**
* @var string The Sentry SDK identifier
*/
protected $sdkIdentifier;

protected string $sdkVersion;
/**
* @var string The Sentry SDK identifier
*/
protected $sdkVersion;

public function __construct(Options $options, string $sdkIdentifier, string $sdkVersion)
{
Expand Down Expand Up @@ -125,7 +134,7 @@ protected function getRequestHeaders(): array
/**
* @TODO(michi) This might need a bit more love,
* but we only really care about X-Sentry-Rate-Limits and Retry-After
*
*
* @return string[]
*/
protected function getResponseHeaders(?int $headerSize, string $body): array

Check warning on line 140 in src/HttpClient/HttpClient.php

View check run for this annotation

Codecov / codecov/patch

src/HttpClient/HttpClient.php#L140

Added line #L140 was not covered by tests
Expand Down
5 changes: 1 addition & 4 deletions src/HttpClient/Response.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,7 @@ class Response
protected $error;

/**
*
* @param int $statusCode
* @param string[] $headers
* @param string $error
* @param string[] $headers
*/
public function __construct(int $statusCode, array $headers, string $error)
{
Expand Down

0 comments on commit e955aae

Please sign in to comment.