ref(ios): Move breadcrumbs conversion to pure obj-c to ensure compatibility with the swift implementation #3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility with the swift implementation
krystofwoldrich
requested review from
brustolin and
vaind
and removed request for
lucas-zimerman
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6e8584e | 447.10 ms | 474.71 ms | 27.61 ms |
| 80b2ce3 | 385.02 ms | 387.36 ms | 2.34 ms |
| 728164b | 414.34 ms | 449.22 ms | 34.88 ms |
| 15c80ab+dirty | 336.27 ms | 350.58 ms | 14.31 ms |
| 457e29f | 398.10 ms | 421.39 ms | 23.29 ms |
| 5bb8d5f | 431.21 ms | 459.40 ms | 28.19 ms |
| d197b5c+dirty | 338.94 ms | 354.87 ms | 15.93 ms |
| 31fcca2 | 391.22 ms | 414.78 ms | 23.56 ms |
| e5c9b8b | 409.02 ms | 426.66 ms | 17.64 ms |
| 12427f4 | 393.69 ms | 414.84 ms | 21.14 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6e8584e | 17.73 MiB | 19.86 MiB | 2.12 MiB |
| 80b2ce3 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| 728164b | 17.73 MiB | 19.85 MiB | 2.12 MiB |
| 15c80ab+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
| 457e29f | 17.73 MiB | 19.84 MiB | 2.10 MiB |
| 5bb8d5f | 17.73 MiB | 19.93 MiB | 2.20 MiB |
| d197b5c+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
| 31fcca2 | 17.73 MiB | 19.90 MiB | 2.17 MiB |
| e5c9b8b | 17.73 MiB | 19.83 MiB | 2.10 MiB |
| 12427f4 | 17.73 MiB | 19.85 MiB | 2.12 MiB |
Fausto95
reviewed
Jun 5, 2024
| NSString * levelString = dict[@"level"]; | ||
| SentryLevel sentryLevel; | ||
| if ([levelString isEqualToString:@"fatal"]) { | ||
| sentryLevel = kSentryLevelFatal; |
There was a problem hiding this comment.
hello @krystofwoldrich,
congrats on the 5.23.0 release tho.
i've just installed it and i'm having some errors due to these variables not being defined.
There was a problem hiding this comment.
There's now an issue to track this issue with the undeclared identifiers: #3863
There was a problem hiding this comment.
Thank you all for the messages and comments, we will release this shorty.
Until then please use the previous SDK release (5.22.3).
This was referenced Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
SentryLevel was moved to Swift in getsentry/sentry-cocoa#3963 and we can't use Swift code in
RNSentry.mm, so I've moved breadcrumb conversion to pure Objective-C implementation.The current implementation works until updating to a release which includes getsentry/sentry-cocoa#3963 changes.
This PR makes RN implementation ready for the future release.
💚 How did you test it?
added unit tests, sample app
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog